Login | Register
My pages Projects Community openCollabNet

Discussions > dev > RE: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java

subclipse
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

RE: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java

Author selsemore
Full name Stephen Elsemore
Date 2011-08-22 06:50:06 PDT
Message My guess would be that we didn’t receive the Delete notifications because our move/delete hook did not trigger them, and the Eclipse delete (which would have triggered them) did not happen. I’ll look into doing everything in our move/delete hook.

 

From: Mark Phippard [mailto:markphip at gmail dot com]
Sent: Monday, August 22, 2011 6:47 AM
To: dev at subclipse dot tigris dot org
Subject: Re: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.​tigris.subversion.su​bclipse.core/src/org​/tigris/subversion/s​ubclipse/core/resour​ces/SVNMoveDeleteHoo​k.java

 

Reading between the lines, it sounds like you are saying you are doing this so that Eclipse will trigger the proper refreshes after the operation completes?

 

Did you look at why our NotificationHandler would not simply do it when it receives the Delete notifications?

 

 

On Mon, Aug 22, 2011 at 9:45 AM, Stephen Elsemore <selsemore at collab dot net> wrote:

Eclipse doesnt have a problem if the resource has actually already been deleted. But I suppose this approach could cause a problem if there is some other move/delete hook in place that will get an error if it tries to handle the delete and the resource is not there. The alternative solution is to make sure our move/delete hook replicates everything that the Eclipse delete does.

From: Mark Phippard [mailto:markphip at gmail dot com]
Sent: Monday, August 22, 2011 6:36 AM
To: dev at subclipse dot tigris dot org
Subject: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.​tigris.subversion.su​bclipse.core/src/org​/tigris/subversion/s​ubclipse/core/resour​ces/SVNMoveDeleteHoo​k.java

Drive by review ...

Is this the right thing to do? Doesn't SVN delete the actual folder/file? Is this change only applying to some specific scenario?

On Mon, Aug 22, 2011 at 9:33 AM, <selsemore at tigris dot org> wrote:

Author: selsemore
Date: 2011-08-22 06:33:24-0700
New Revision: 5091

Modified:
trunk/subclipse/org.​tigris.subversion.su​bclipse.core/src/org​/tigris/subversion/s​ubclipse/core/resour​ces/SVNMoveDeleteHoo​k.java

Log:
Move/delete hook should return false for deleteFile and deleteFolder methods
(so that Eclipse will do its thing and do the actual delete after Subclipse
is done).

Modified: trunk/subclipse/org.​tigris.subversion.su​bclipse.core/src/org​/tigris/subversion/s​ubclipse/core/resour​ces/SVNMoveDeleteHoo​k.java
Url: http://subclipse.tig​ris.org/source/brows​e/subclipse/trunk/su​bclipse/org.tigris.s​ubversion.subclipse.​core/src/org/tigris/​subversion/subclipse​/core/resources/SVNM​oveDeleteHook.java?v​iew=diff&pathrev​=5091&r1=5090​&r2=5091
====================​====================​====================​==================
--- trunk/subclipse/org.​tigris.subversion.su​bclipse.core/src/org​/tigris/subversion/s​ubclipse/core/resour​ces/SVNMoveDeleteHoo​k.java (original)
+++ trunk/subclipse/org.​tigris.subversion.su​bclipse.core/src/org​/tigris/subversion/s​ubclipse/core/resour​ces/SVNMoveDeleteHoo​k.java 2011-08-22 06:33:24-0700
@@ -74,15 +74,12 @@
deletedFiles.add(file);

deleteResource(resource);
-
- tree.deletedFile(file);
-
} catch (SVNException e) {
tree.failed(e.getStatus());
} finally {
monitor.done();
}
- return true;
+ return false;

}

@@ -113,8 +110,7 @@
} finally {
monitor.done();
}
- return true;
-
+ return false;
}

/*

--------------------​--------------------​--------------
http://subclipse.tig​ris.org/ds/viewMessa​ge.do?dsForumId=3541​&dsMessageId=282​7597

To unsubscribe from this discussion, please e-mail [unsubscribeURL]





--
Thanks

Mark Phippard
http://markphip.blogspot.com/





 

--
Thanks

Mark Phippard
http://markphip.blogspot.com/
Attachments
attachment-3348362

« Previous message in topic | 4 of 7 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
[Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java markphip Mark Phippard 2011-08-22 06:35:47 PDT
     RE: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java selsemore Stephen Elsemore 2011-08-22 06:45:38 PDT
         Re: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java markphip Mark Phippard 2011-08-22 06:47:36 PDT
             RE: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java selsemore Stephen Elsemore 2011-08-22 06:50:06 PDT
                 Re: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java markphip Mark Phippard 2011-08-22 06:53:42 PDT
                     RE: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java selsemore Stephen Elsemore 2011-08-22 06:55:55 PDT
         Re: [Subclipse-dev] Re: subclipse svn commit: r5091 - trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java jcompagner jcompagner 2011-08-22 08:43:35 PDT
Messages per page: