Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [PATCH] toggle "show change path by default"

subclipse
Discussion topic

Back to topic list

Re: [PATCH] toggle "show change path by default"

Author br
Full name Bernd Rinn
Date 2005-08-01 06:49:20 PDT
Message It turned out to be pretty simple to implement that on top of Eugene's
patch. I have attached the patch (to be applied to HistoryView.java).

Just one comment regarding the patch and two general question:

* I would suggest renaming the actions toggleTextWrapAction,
toggleTextAction, and toggleListAction to something more descriptive, e.g.
  toggleTextWrapAction -> toggleWrapCommentsAction,
  toggleTextAction -> toggleShowComments,
  toggleListAction -> toggleShowAffectedPathsAction.

* What's the preferred way of submitting subclipse patches: sending them
do the dev mailing list or putting them into the issue tracker?

* Is there a general rule for Eclipse (or more specifically Subclipse)
when to put some persistent setting into the preferences dialog and when
to keep them 'local' to e.g. a view?

Mark wrote:

> We will probably landing this on trunk sometime soon. The patch
> submitter, Eugene Kuleshov went on vacation last week.

> Anyway, he is combining many enhancements in his patch, but the one
> that is relevant here are view options to hide/show the affected paths
> and/orcomment. I would suggest that you combine your patch with his,
> so that when the user has hidden the affected paths part of the view,
> then it does not fetch them.
>
> If it is easier, you could just wait until his patch lands on trunk.
>
> Mark


Bernd Rinn wrote:
> This is a follow up mail to my email "Fetch affected paths on demand" to
> the users list.
>
> There I asked for a possibility to disable fetching affected paths in
> the SVN history view. The rationale behind this feature request is that
> fetching affected paths can be an expensive operation, even with "Fetch
> affected paths on demand" enabled. Especially when linking the SVN
> history view to the editor this can become an issue. Since in subclipse
> 0.9.32 it can't be disabled, I have implemented it. Please find the
> patches to core and ui attached.
>
> The patches adds two things:
> * A context menu for the tableChangePathViewer that contains one toggle
> menu item "Show affected paths". When it is switched off, affected paths
> are no longer fetched, until it is switched on again.
>
> * A preference "Show affected paths by default". This preference
> controls the default value of the menu item above.
>
> Of course it would be great if the patches could go into trunk, because
> then I wouldn't have to maintain them for new versions of subclipse. ;-)
> But even if they can't go in for some reason I would be interested in
> feedback.

--
Bernd Rinn
Attachments

« Previous message in topic | 2 of 24 | Next message in topic »

Messages

Show all messages in topic

[PATCH] toggle "show change path by default" br Bernd Rinn 2005-07-31 08:47:57 PDT
     Re: [PATCH] toggle "show change path by default" br Bernd Rinn 2005-08-01 06:49:20 PDT
         Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-01 07:02:16 PDT
         Re: [PATCH] toggle "show change path by default" br Bernd Rinn 2005-08-18 14:31:48 PDT
             Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 14:47:13 PDT
                 resorce text decorators Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 22:48:15 PDT
                     Re: [Subclipse-dev] resorce text decorators Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 06:48:10 PDT
                         Re: [Subclipse-dev] resorce text decorators Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:08:49 PDT
                             Re: [Subclipse-dev] resorce text decorators Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 07:09:52 PDT
                                 Re: [Subclipse-dev] resorce text decorators Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:50:25 PDT
                                     Re: [Subclipse-dev] resorce text decorators eu Eugene Kuleshov 2005-08-21 11:14:42 PDT
                                         issues reported by FindBugs on org.tigris.subversion.subclipse.core eu Eugene Kuleshov 2005-08-21 12:56:54 PDT
                                             issues reported by FindBugs on org.tigris.subversion.subclipse.ui eu Eugene Kuleshov 2005-08-21 13:08:57 PDT
                                                 issues reported by FindBugs on svnClientAdapter eu Eugene Kuleshov 2005-08-21 13:19:48 PDT
                                         Re: [Subclipse-dev] resorce text decorators Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-21 18:13:25 PDT
             Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-18 17:53:16 PDT
                 Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 22:07:10 PDT
                     Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 23:07:35 PDT
                         Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 06:44:26 PDT
                             Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 06:56:39 PDT
                     Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 06:50:30 PDT
                         Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:34:34 PDT
                             RE: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" letenay Martin Letenay 2005-08-19 07:43:52 PDT
                                 Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:55:42 PDT
Messages per page: