Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [PATCH] toggle "show change path by default"

subclipse
Discussion topic

Back to topic list

Re: [PATCH] toggle "show change path by default"

Author br
Full name Bernd Rinn
Date 2005-08-18 14:31:48 PDT
Message >Bernd Rinn <bernd at sdf dot lonestar dot org> wrote on 08/01/2005 09:49:20 AM:
>
>> It turned out to be pretty simple to implement that on top of >Eugene's
>> patch. I have attached the patch (to be applied to HistoryView.java).
>>
>> Just one comment regarding the patch and two general question:
>>
>> * I would suggest renaming the actions toggleTextWrapAction,
>> toggleTextAction, and toggleListAction to something more descriptive,
>e.g.
>> toggleTextWrapAction -> toggleWrapCommentsAction,
>> toggleTextAction -> toggleShowComments,
>> toggleListAction -> toggleShowAffectedPathsAction.
>
>Eugene, can you try to incorporate this stuff into your patch? I would
>still like to see this part of the patch separated from the rest.
>
>> * What's the preferred way of submitting subclipse patches: sending
>>them
>> do the dev mailing list or putting them into the issue tracker?
>>
>I like to see it go to the issue tracker because email can mess up the
>patch. Of course, you can always post something to dev@ after adding >an
>item to the issue tracker.

Sorry, I am not allowed to add a comment to issue #349, so I am sending
an email anyway.

Eugene doesn't seem to have time to prepare the HistoryView patch. Since
I would like to see that functionality in 0.9.33, I have prepared a
patch that applies cleanly against revision 1555 and that doesn't
contain the context menu for the "affected paths" table (which takes
quite long to appear). I've tested the patch and it works fine for me.
Could anyone else give it a test?

Bernd

--
Bernd Rinn
Attachments

« Previous message in topic | 4 of 24 | Next message in topic »

Messages

Show all messages in topic

[PATCH] toggle "show change path by default" br Bernd Rinn 2005-07-31 08:47:57 PDT
     Re: [PATCH] toggle "show change path by default" br Bernd Rinn 2005-08-01 06:49:20 PDT
         Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-01 07:02:16 PDT
         Re: [PATCH] toggle "show change path by default" br Bernd Rinn 2005-08-18 14:31:48 PDT
             Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 14:47:13 PDT
                 resorce text decorators Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 22:48:15 PDT
                     Re: [Subclipse-dev] resorce text decorators Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 06:48:10 PDT
                         Re: [Subclipse-dev] resorce text decorators Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:08:49 PDT
                             Re: [Subclipse-dev] resorce text decorators Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 07:09:52 PDT
                                 Re: [Subclipse-dev] resorce text decorators Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:50:25 PDT
                                     Re: [Subclipse-dev] resorce text decorators eu Eugene Kuleshov 2005-08-21 11:14:42 PDT
                                         issues reported by FindBugs on org.tigris.subversion.subclipse.core eu Eugene Kuleshov 2005-08-21 12:56:54 PDT
                                             issues reported by FindBugs on org.tigris.subversion.subclipse.ui eu Eugene Kuleshov 2005-08-21 13:08:57 PDT
                                                 issues reported by FindBugs on svnClientAdapter eu Eugene Kuleshov 2005-08-21 13:19:48 PDT
                                         Re: [Subclipse-dev] resorce text decorators Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-21 18:13:25 PDT
             Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-18 17:53:16 PDT
                 Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 22:07:10 PDT
                     Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-18 23:07:35 PDT
                         Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 06:44:26 PDT
                             Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 06:56:39 PDT
                     Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Mark Phippard <MarkP at softlanding dot com> Mark Phippard <MarkP at softlanding dot com> 2005-08-19 06:50:30 PDT
                         Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:34:34 PDT
                             RE: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" letenay Martin Letenay 2005-08-19 07:43:52 PDT
                                 Re: [Subclipse-dev] Re: [PATCH] toggle "show change path by default" Eugene Kuleshov <eu at javatx dot com> Eugene Kuleshov <eu at javatx dot com> 2005-08-19 07:55:42 PDT
Messages per page: