Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [Subclipse-dev] Added compare to commit dialog.

subclipse
Discussion topic

Back to topic list

Re: [Subclipse-dev] Added compare to commit dialog.

Author jespersm
Full name Jesper Steen Møller
Date 2006-01-27 07:10:03 PST
Message >Mark Phippard <markp at softlanding dot com> wrote on 01/27/2006 08:45:02 AM:
>
>One thing that may not have been clear, I am +1 on this change and thanks
>for doing it. I was just posting my reasons why I had not done it yet. I
>have been thinking of ways to have the commit dialog itself have an
>expanded view to show the compare, and just had not had the motivation to
>try it.

This will create one big, fat dialog. Perhaps this is better, though.

I have a different idea which I put into the bug report, to make a new compare dialog (which is neccessary anyway to fix the issue with the file being editable and the wrong buttons) which also has a commit message edit field, so you could "carry the text around" while looking at the diffs for each file.

>Other option would be to work on making the commit dialog modeless and
>then open the compare in normal editor. I think that idea opens a lot of
>possibilities for buggy commit behavior.

Mabye make the Pending Operations View (of which I'm very fond) a sashform with an editing field to type the commit message into, and when the user clicks commit, carry that text into the editor?

Mabye rename it "Pending Commit View"... That's a wholly different approach, but in a way it accomplishes the same goal.

-Jesper

« Previous message in topic | 1 of 14 | Next message in topic »

Messages

Show all messages in topic

Re: [Subclipse-dev] Added compare to commit dialog. jespersm Jesper Steen Møller 2006-01-27 07:10:03 PST
     Re: [Subclipse-dev] Added compare to commit dialog. Mark Phippard <markp at softlanding dot com> Mark Phippard <markp at softlanding dot com> 2006-01-27 06:58:28 PST
         Action view? (was: Re: [Subclipse-dev] Added compare to commit dialog.) denny Denny Valliant 2006-02-06 18:40:26 PST
             Re: [Subclipse-dev] Action view? eu Eugene Kuleshov 2006-02-06 18:42:14 PST
                 Re: [Subclipse-dev] Action view? denny Denny Valliant 2006-02-06 19:26:07 PST
                     Re: [Subclipse-dev] Action view? eu Eugene Kuleshov 2006-02-06 19:37:18 PST
                         Re: [Subclipse-dev] Action view? denny Denny Valliant 2006-02-06 23:59:52 PST
                             Re: [Subclipse-dev] Action view? eu Eugene Kuleshov 2006-02-07 00:47:02 PST
                                 Re: [Subclipse-dev] Action view? denny Denny Valliant 2006-02-07 02:58:19 PST
                         Re: [Subclipse-dev] Action view? jespersm Jesper Steen Møller 2006-02-07 01:03:50 PST
                             Re: [Subclipse-dev] Action view? eu Eugene Kuleshov 2006-02-07 10:04:45 PST
                                 Re: [Subclipse-dev] Action view? denny Denny Valliant 2006-02-07 16:22:56 PST
                 Re: [Subclipse-dev] Action view? Mark Phippard <markp at softlanding dot com> Mark Phippard <markp at softlanding dot com> 2006-02-07 05:48:35 PST
                     Re: [Subclipse-dev] Action view? jespersm Jesper Steen Møller 2006-02-07 08:21:43 PST
Messages per page: