Login | Register
My pages Projects Community openCollabNet

Discussions > cvs > subclipse commit: r1424 - trunk/subclipse/ui/src/org/tigris/subversion/subclipse/ui/operations

subclipse
Discussion topic

Back to topic list

subclipse commit: r1424 - trunk/subclipse/ui/src/org/tigris/subversion/subclipse/ui/operations

Author markphip
Full name Mark Phippard
Date 2005-06-30 17:47:40 PDT
Message Author: markphip
Date: Thu Jun 30 19:47:32 2005
New Revision: 1424

Modified:
   trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/op​erations/CommitOpera​tion.java

Log:
Commented out some seemingly unnecessary but very performance damaging code.

Post commit was doing a bunch of resource refreshes, but the notification framework
already does this. Everything seems to still work correctly and is noticeably
faster.

Suggested by Alexander Kitaev

Modified: trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/op​erations/CommitOpera​tion.java
Url: http://svn.collab.ne​t/viewcvs/subclipse/​trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/op​erations/CommitOpera​tion.java?rev=1424​&p1=trunk/subclips​e/ui/src/org/tigris/​subversion/subclipse​/ui/operations/Commi​tOperation.java&​p2=trunk/subclipse/u​i/src/org/tigris/sub​version/subclipse/ui​/operations/CommitOp​eration.java&r1=​1423&r2=1424
====================​====================​====================​==================
--- trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/op​erations/CommitOpera​tion.java (original)
+++ trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/op​erations/CommitOpera​tion.java Thu Jun 30 19:47:32 2005
@@ -64,10 +64,10 @@
                 IResource[] providerResources = (IResource[])list.toArray(new IResource[list.size()]);
                 provider.checkin(pro​viderResources, commitComment, keepLocks, getDepth(providerResources), null);
             }
- for (int i = 0; i < selectedResources.length; i++) {
- IResource projectHandle = selectedResources[i]​.getProject();
- projectHandle.refres​hLocal(IResource.DEP​TH_INFINITE, monitor);
- }
+// for (int i = 0; i < selectedResources.length; i++) {
+// IResource projectHandle = selectedResources[i]​.getProject();
+// projectHandle.refres​hLocal(IResource.DEP​TH_INFINITE, monitor);
+// }
         } catch (TeamException e) {
             throw SVNException.wrapException(e);
         } catch (CoreException e) {

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

subclipse commit: r1424 - trunk/subclipse/ui/src/org/tigris/subversion/subclipse/ui/operations markphip Mark Phippard 2005-06-30 17:47:40 PDT
Messages per page: