Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 1404] New - SHIFT+ENTER auto-commits without prompt

subclipse
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

[Issue 1404] New - SHIFT+ENTER auto-commits without prompt

Author hfortier
Full name Harrison Fortier
Date 2012-04-13 11:05:32 PDT
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1404
                 Issue #|1404
                 Summary|SHIFT+ENTER auto-commits without prompt
               Component|subclipse
                 Version|1.6.x
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|UI
             Assigned to|issues@subclipse
             Reported by|hfortier






------- Additional comments from hfortier at tigris dot org Fri Apr 13 11:05:31 -0700 2012 -------
This may be applicable to newer versions as well.

Steps to reproduce:
1) Select several modified or new files in your package explorer / project
explorer view.
2) Right click -> Commit
3) Commit dialog appears.
4) Start typing in commit notes.
5) Accidentally hit SHIFT+ENTER
6) All files are committed without warning / prompt.

Needless to say, this is very aggravating as there is no easy way to undo a
commit and fix your notes unless you are an administrator to your repository (I
am not).

Additionally, if you did not first review the files and un-check the ones you
didn't want to commit, and decided to start typing your commit notes first and
accidentally hit SHIFT+ENTER (the keys are right next to each other so this is
very easy to do) then you just committed a bunch of files that you may not have
reviewed, and should not have been committed.

SHIFT+ENTER is terrible. Several reasons:
1) The keys sit next to each other and so it is very easy to hit both keys with
a single finger. This can occur when you mean to hit shift, or you mean to hit
enter. Either case is very frequent when typing up detailed commit notes.

2) Many IM clients (like Pidgin, or even facebook) use ENTER to submit a
message. So in order to have a message with newlines in it, you use SHIFT+ENTER.
Additionally, in MS Outlook when composing a new message, the ENTER key creates
a new paragraph (depending on your settings) - two new lines. So the only way to
force a single newline is to use SHIFT+ENTER. In short: SHIFT+ENTER is commonly
used to produce a newline character across a wide variety of application. I
might note that even in eclipse itself - SHIFT+ENTER produces a newline
character. So this behavior is completely inconsistent with Eclipse itself.


Suggested resolution choices:
1) Disable SHIFT+ENTER key combination from auto-committing completely.
OR
2) Add the ability to make this a preference so SHIFT+ENTER auto-committing can
be disabled.
OR
3) Add a warning / confirmation dialog when SHIFT+ENTER is pressed. I would note
that this is the worst option, as if someone is typing fast they could queue up
several enter keystrokes which then would also effectively automatically say
"YES" to the commit dialog.

I prefer option 1 or 2. Option 2 is probably the best - should some people like
SHIFT+ENTER for shortcut committing.

« Previous message in topic | 1 of 3 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
[Issue 1404] New - SHIFT+ENTER auto-commits without prompt hfortier Harrison Fortier 2012-04-13 11:05:32 PDT
     [Issue 1404] SHIFT+ENTER auto-commits without prompt selsemore Stephen Elsemore 2012-04-13 13:23:18 PDT
     [Issue 1404] SHIFT+ENTER auto-commits without prompt hfortier Harrison Fortier 2012-04-13 13:46:49 PDT
Messages per page: