Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 1505] New - Methods 'copy(srcPath, destURL...)' lack a 'version' parameter

subclipse
Discussion topic

Back to topic list

[Issue 1505] New - Methods 'copy(srcPath, destURL...)' lack a 'version' parameter

Author arno_unkrig
Full name Arno Unkrig
Date 2013-04-24 04:08:17 PDT
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1505
                 Issue #|1505
                 Summary|Methods 'copy(srcPath, destURL...)' lack a 'version' p
                        |arameter
               Component|svnClientAdapter
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|svnClientAdapter
             Assigned to|issues@subclipse
             Reported by|arno_unkrig






------- Additional comments from arno_unkrig at tigris dot org Wed Apr 24 04:08:17 -0700 2013 -------
Interface 'ISVNClientAdapter' declares

  public abstract void copy(File srcPath, SVNUrl destUrl, String message);
  public abstract void copy(File[] srcPaths, SVNUrl destUrl, String message,
boolean copyAsChild, boolean makeParents);

, but these should have an additional 'revision' parameter, because the default
is not what you always want ('WORKING', as defined in

http://subclipse.tig​ris.org/source/brows​e/subclipse/trunk/sv​nClientAdapter/src/j​
avahl/org/tigris/sub​version/svnclientada​pter/javahl/Abstract​JhlClientAdapter.jav​
a?revision=5608&view=markup

). I suggest that there be a new method

  public void copy(File[] srcPaths, SVNRevision revision, SVNRevision
pegRevision, SVNUrl destUrl, String message, boolean copyAsChild, boolean
makeParents)

in the 'ISVNClientAdapter' and implemented in 'AbstractJhlClientAdapter'. The
implementation should be straightforward.

« Previous message in topic | 1 of 2 | Next message in topic »

Messages

Show all messages in topic

[Issue 1505] New - Methods 'copy(srcPath, destURL...)' lack a 'version' parameter arno_unkrig Arno Unkrig 2013-04-24 04:08:17 PDT
     [Issue 1505] Methods 'copy(srcPath, destURL...)' lack a 'version' parameter arno_unkrig Arno Unkrig 2016-01-18 00:44:21 PST
Messages per page: