Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 1181] New - Commit skipped, no error

subclipse
Discussion topic

Hide all messages in topic

All messages in topic

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-16 13:56:30 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from timothyja at tigris dot org Thu Dec 16 13:56:29 -0800 2010 -------
Created an attachment (id=334)
Rational Software Architect Error Dialog

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-16 13:54:48 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from timothyja at tigris dot org Thu Dec 16 13:54:47 -0800 2010 -------
No there is no Message dialog I also came to the conclusion that an Exception is
probably not being thrown. The fix I sent only addresses the missing Console
output which is a big help in determining why the commit failed.

SVNKit seems to not throw Exceptions when is sends Skipped Notifications, you
can test this by enabling the pre-commit hook and enabling the default commit
without a comment hook. When you commit something without a comment you will see
the behaviour this bug describes.

On the other hand if you put a hook in to stop a delete, this time a dialog box
will be displayed. Again this appears to be because an Exception is being thrown
by SVNKit. It seems to be intentional not to thrown an Exception for some cases
such as commits, although I'm not sure why.

Finally (although maybe I should open anouther bug for this) when using IBM's
Rational Software Architect instead of Eclipse the error dialog presents an
option to report the error to IBM (I will attach a screenshot). This appears to
be a side affect the way these exceptions are handled and displayed by Subclipse.

[Issue 1181] Commit skipped, no error

Author markphip
Full name Mark Phippard
Date 2010-12-16 04:32:22 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from markphip at tigris dot org Thu Dec 16 04:32:21 -0800 2010 -------
Thanks. Does it work completely as you expected with an error dialog too? I guess the log.error messages
might do that, but Steve and I were wondering if the problem there was that SVNKit was not throwing an
Exception or something like that.

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-15 22:31:44 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from timothyja at tigris dot org Wed Dec 15 22:31:44 -0800 2010 -------
Thanks for the quick reply. The version you commited works :-)

In future I will create a patch I had never used that feature before.

Cheers,
Tim

[Issue 1181] Commit skipped, no error

Author markphip
Full name Mark Phippard
Date 2010-12-15 05:30:09 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181



User markphip changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                  Status|NEW |RESOLVED
--------------------​--------------------​--------------------​--------------------​
              Resolution| |FIXED
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from markphip at tigris dot org Wed Dec 15 05:30:08 -0800 2010 -------
Thanks. I committed the change in r4772. Can you try the version I committed? I made a small tweak to
not issue the Skipped message if we have an error. This should avoid the Skipped null message.

I hope you will consider making more contributions in the future. If you do, rather than giving us the
enture file please use the Team > Create Patch option and send us that instead.

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-15 03:47:23 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from timothyja at tigris dot org Wed Dec 15 03:47:23 -0800 2010 -------
Ok the issue seems to be that Subclise see's the Skipped NotifyAction and prints
this message but ignores the error message that is issued with it. This can be
fixed by checking for an error message and logging it out if it exists.

Project: org.tigris.subversio​n.clientadapter.svnk​it
Package: org.tigris.subversio​n.svnclientadapter.j​avahl
Class: JhlNotificationHandler

I have attached the updated class that fixes the console output

The only thing that remains is I have not figured out how the Message Dialog is
triggered, can anyone point me in the right direction?

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-15 03:45:26 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from timothyja at tigris dot org Wed Dec 15 03:45:26 -0800 2010 -------
Created an attachment (id=333)
Fix for missing console output

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-13 18:27:35 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181



User timothyja changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                      CC|'mauromol' |'mauromol,timothyja'
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from timothyja at tigris dot org Mon Dec 13 18:27:34 -0800 2010 -------
Cc

[Issue 1181] Commit skipped, no error

Author timothyja
Full name Timothy Fridey
Date 2010-12-13 18:24:38 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from timothyja at tigris dot org Mon Dec 13 18:24:37 -0800 2010 -------
As mentioned in the thread SVNKit does return and error message the problem is
Subclipse doesn't pick it up:

The SVN repo I'm using is currently locked using a
commit-hook, but that's not particularly relevant.

In Eclipse+SVNKit, I just get the message "Skipped" in the Console;
there is no indication of an error anywhere.

Switch to Eclipse+JavaHL and I get a message such as:

svn: Commit failed (details follow):
svn: Commit blocked by start-commit hook (exit code 1) with output:
Write access is currently disabled.

There is also a popup dialog box with the same information, so it's
really obvious the the commit has failed.

Now when I use the jsvn command-line version of the same version of
SVNkit, I get the message:

Skipped 'null'
svn: Commit failed (details follow):
svn: Commit blocked by start-commit hook (exit code 1) with output:
Write access is currently disabled.

This suggests that the problem may be in Subclipse rather than SVNkit,
as clearly SVNkit can return the error details to the caller.

[Issue 1181] Commit skipped, no error

Author mauromol
Full name Mauro Molinari
Date 2010-11-17 05:36:38 PST
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181



User mauromol changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                      CC|'' |'mauromol'
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from mauromol at tigris dot org Wed Nov 17 05:36:38 -0800 2010 -------
Cc

[Issue 1181] Commit skipped, no error

Author jacobweber
Full name Jacob Weber
Date 2010-08-09 11:57:32 PDT
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181



User jacobweber changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                Platform|JavaHL |SVNKit
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from jacobweber at tigris dot org Mon Aug 9 11:57:31 -0700 2010 -------
My mistake -- I had SVNKit selected.

[Issue 1181] Commit skipped, no error

Author markphip
Full name Mark Phippard
Date 2010-08-09 11:54:04 PDT
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181



User markphip changed the following:

                What |Old value |New value
====================​====================​====================​====================​
                     URL| |http://subclipse.tigris.or
                        | |g/ds/viewMessage.do?dsForu
                        | |mId=1047&dsMessageId=26300
                        | |31
--------------------​--------------------​--------------------​--------------------​




------- Additional comments from markphip at tigris dot org Mon Aug 9 11:54:03 -0700 2010 -------
Here is the thread:

http://subclipse.tig​ris.org/ds/viewMessa​ge.do?dsForumId=1047​&dsMessageId=263​0031

[Issue 1181] Commit skipped, no error

Author markphip
Full name Mark Phippard
Date 2010-08-09 11:52:39 PDT
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181






------- Additional comments from markphip at tigris dot org Mon Aug 9 11:52:38 -0700 2010 -------
I seem to recall someone reporting this on users@ semi-recently and we determined it was an SVNKit
problem.

[Issue 1181] New - Commit skipped, no error

Author jacobweber
Full name Jacob Weber
Date 2010-08-09 11:37:52 PDT
Message http://subclipse.tig​ris.org/issues/show_​bug.cgi?id=1181
                 Issue #|1181
                 Summary|Commit skipped, no error
               Component|subclipse
                 Version|current
                Platform|JavaHL
              OS/Version|Mac OS X
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|core
             Assigned to|issues@subclipse
             Reported by|jacobweber






------- Additional comments from jacobweber at tigris dot org Mon Aug 9 11:37:51 -0700 2010 -------
I have version 1 of a file checked out. Someone committed version 2, but I didn't update. I made a
change, and tried to commit it. In the SVN console, this was the output:

commit -m "my comment" /path/to/file
    Sending /path/to/file
    Transmitting file data ...
    Skipped

There was no error message, or any indication that the commit didn't succeed. I didn't have the SVN
console open, so I didn't see it there. The only reason I noticed was that the label decoration didn't
change on the file.

I think there should be some sort of alert that appears when a commit fails.
Messages per page: