Login | Register
My pages Projects Community openCollabNet

Discussions > commits > svn commit: r1453 - in trunk: subclipse/ui/src/org/tigris/subversion/subclipse/ui/repository www/subclipse

subclipse
Discussion topic

Back to topic list

svn commit: r1453 - in trunk: subclipse/ui/src/org/tigris/subversion/subclipse/ui/repository www/subclipse

Author markphip
Full name Mark Phippard
Date 2005-07-14 05:44:54 PDT
Message Author: markphip
Date: Thu Jul 14 05:44:53 2005
New Revision: 1453

Modified:
   trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/re​pository/RemoveRootA​ction.java
   trunk/www/subclipse/​changes.html
Log:
When discarding a location we get a list of all projects being managed by
Subclipse. We then call getRepository() on each project so that we can
verify that none of the projects are attached to the one being deleted.

getRepository() can throw an exception if the project does not have a .svn
folder.

In theory, in this scenario, that situation should not be able to
happen. However, in this case, it makes sense to just catch that Exception
and let the process continue.


Modified: trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/re​pository/RemoveRootA​ction.java
Url: http://subclipse.tig​ris.org/source/brows​e/subclipse/trunk/su​bclipse/ui/src/org/t​igris/subversion/sub​clipse/ui/repository​/RemoveRootAction.ja​va?view=diff&rev​=1453&p1=trunk/s​ubclipse/ui/src/org/​tigris/subversion/su​bclipse/ui/repositor​y/RemoveRootAction.j​ava&r1=1452&​p2=trunk/subclipse/u​i/src/org/tigris/sub​version/subclipse/ui​/repository/RemoveRo​otAction.java&r2​=1453
====================​====================​====================​==================
--- trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/re​pository/RemoveRootA​ction.java (original)
+++ trunk/subclipse/ui/s​rc/org/tigris/subver​sion/subclipse/ui/re​pository/RemoveRootA​ction.java Thu Jul 14 05:44:53 2005
@@ -82,10 +82,15 @@
                 for (int j = 0; j < projects.length; j++) {
                     RepositoryProvider teamProvider = RepositoryProvider.g​etProvider(projects[​j], SVNProviderPlugin.getTypeId());
                     if (teamProvider!=null) {
- SVNTeamProvider svnProvider = (SVNTeamProvider)teamProvider;
- if (svnProvider.getSVNW​orkspaceRoot().getRe​pository().equals(ro​ots[i])) {
- shared.add(projects[j]);
- }
+ try {
+ SVNTeamProvider svnProvider = (SVNTeamProvider)teamProvider;
+ if (svnProvider.getSVNW​orkspaceRoot().getRe​pository().equals(ro​ots[i])) {
+ shared.add(projects[j]);
+ }
+ } catch(Exception e) {
+ // Don't let any exception prevent from
+ // continuing
+ }
                     }
                 }
             

Modified: trunk/www/subclipse/​changes.html
Url: http://subclipse.tig​ris.org/source/brows​e/subclipse/trunk/ww​w/subclipse/changes.​html?view=diff&r​ev=1453&p1=trunk​/www/subclipse/chang​es.html&r1=1452​&p2=trunk/www/sub​clipse/changes.html​&r2=1453
====================​====================​====================​==================
--- trunk/www/subclipse/​changes.html (original)
+++ trunk/www/subclipse/​changes.html Thu Jul 14 05:44:53 2005
@@ -110,6 +110,8 @@
  never been modified in its current location, such as when working in a new
  branch or when a file has been moved.</li>
  <li>Show Annotations should now work with the Command Line Adapter</li>
+ <li>Handle an exception that can occur when discarding a repository location and checking
+ for projects that might still be attached to that location.</li>
 </ul>
 <hr />
 <a name="0.9.31"></a>

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

svn commit: r1453 - in trunk: subclipse/ui/src/org/tigris/subversion/subclipse/ui/repository www/subclipse markphip Mark Phippard 2005-07-14 05:44:54 PDT
Messages per page: