Login | Register
My pages Projects Community openCollabNet

Discussions > dev > [Subclipse-dev] setIgnored() in org.tigris.subversion.subclipse.core.resources.LocalResource

subclipse
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

[Subclipse-dev] setIgnored() in org.tigris.subversion.subclipse.core.resources.LocalResource

Author biczok at freemail dot hu
Full name biczok at freemail dot hu
Date 2009-01-05 08:43:45 PST
Message Hi,

Seems like when anyone calls setIgnored() in LocalResource.java it will end up throwing a NullPointerException.
The reason is that it calls the run() method of a newly created AddIgnoredPatternCommand with a null IProgressMonitor.

The actual code is this:

    public void setIgnored() throws SVNException {
        AddIgnoredPatternCommand command = new AddIgnoredPatternCom​mand(getParent(), resource.getName());
        command.run(null);
    }

Maybe nobody is calling this method currently, but shouldn't it do something like:

        command.run(new NullProgressMonitor());

to avoid future surprises?

Cheers,

Laca

« Previous message in topic | 1 of 2 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
[Subclipse-dev] setIgnored() in org.tigris.subversion.subclipse.core.resources.LocalResource biczok at freemail dot hu biczok at freemail dot hu 2009-01-05 08:43:45 PST
     Re: [Subclipse-dev] setIgnored() in org.tigris.subversion.subclipse.core.resources.LocalResource selsemore Stephen Elsemore 2009-01-05 11:04:05 PST
Messages per page: